missing_field_behavior 's default to ignore#56
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| it { is_expected.to be_a TestFixture::Simple::Message } | ||
| end | ||
|
|
||
| context 'when missing_field_behavior is not configured (default behavior)' do |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| # Override the parent's before block to avoid setting missing_field_behavior | ||
| let(:missing_field_behavior) { nil } | ||
|
|
||
| it 'uses default value :ignore' do |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| spec.add_development_dependency "sqlite3", "~> 1.4" | ||
| spec.add_development_dependency "simplecov", "~> 0.18.5" | ||
| spec.add_development_dependency "simplecov-cobertura", "~> 1.3" | ||
| spec.add_development_dependency "concurrent-ruby", "1.3.4" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Gemspec/OrderedDependencies: Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency concurrent-ruby should appear before simplecov-cobertura.
| # ruby: [ 2.5, 2.6, 2.7, 3.0 ] | ||
| ruby: [ 2.5, 2.6, 2.7 ] | ||
| exclude: | ||
| - { os: macos-latest, ruby: '2.5' } |
There was a problem hiding this comment.
macos-latestの2.5はもうサポートされていなかったので、
excludeを使ってみようとすると、Expected — Waiting for status to be reported なってしまいCIが
終わらない。
There was a problem hiding this comment.
Branch Protection Rule で、Status checks that are required からも消す必要があります（わかりづらいですよね... 自分も前にハマりました）
https://github.com/wantedly/pb-serializer/settings/branch_protection_rules/15047227
There was a problem hiding this comment.
CI で動かしている Ruby のバージョン、[ 2.5, 2.6, 2.7 ] だと古すぎるので、3.0 以降とかにしてしまっていいと思いますね。
gemspec にある Rails （activerecord）のバージョン指定が、rails_versions = [">= 5.2", "< 6.1"] になっているので、Rails バージョンも一緒に上げてしまいたいですね。
差分多くなりそうなので、別PRでやりましょう。
| spec.add_development_dependency "sqlite3", "~> 1.4" | ||
| spec.add_development_dependency "simplecov", "~> 0.18.5" | ||
| spec.add_development_dependency "simplecov-cobertura", "~> 1.3" | ||
| spec.add_development_dependency "simplecov", "~> 0.19" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Gemspec/OrderedDependencies: Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency simplecov should appear before sqlite3.
hiraokashi
deleted the
hiraokashi/change_missing_field_behavior_default
branch
3 participants
Why
https://github.com/wantedly/backend-chapter/issues/174
What